linux-kernel - Re: ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 May 2021 16:46:20 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rich Felker <dalias@...c.org>,
        David Daney <david.daney@...ium.com>
Subject: Re: ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko]
 undefined!

> > No, we should just fix the driver instead.
> > 
> > +               /* Wait 1000 clocks so we don't saturate the RSL bus
> > +                * doing reads.
> > +                */
> > +               __delay(1000);
> > 
> > As this is used only on Cavium Octeon and Thunder SoCs, running
> > at 400-600 MHz resp. 1800-2000 Mhz, what about replacing the __delay()
> > call by a call to udelay(1) or udelay(2)?
> 
> Yeah, I was planning to look into that change this week,
> but it would probably be better for David to do it.

If you look at the bigger picture, using linux/iopoll.h would be a
better solution.

       Andrew