linux-kernel - Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLSRR7kHZF+fj7k4@pendragon.ideasonboard.com>
Date:   Mon, 31 May 2021 10:33:27 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     vkoul@...nel.org, yoshihiro.shimoda.uh@...esas.com,
        geert+renesas@...der.be, wsa+renesas@...g-engineering.com,
        robin.murphy@....com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in
 rcar_dmac_probe()

Hi Zou,

Thank you for the patch.

On Mon, May 31, 2021 at 02:36:03PM +0800, Zou Wei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/dma/sh/rcar-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index d530c1b..6885b3d 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1913,7 +1913,7 @@ static int rcar_dmac_probe(struct platform_device *pdev)
>  
>  	/* Enable runtime PM and initialize the device. */
>  	pm_runtime_enable(&pdev->dev);
> -	ret = pm_runtime_get_sync(&pdev->dev);
> +	ret = pm_runtime_resume_and_get(&pdev->dev);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret);
>  		return ret;

-- 
Regards,

Laurent Pinchart