linux-kernel - Re: [PATCH] perf/x86/rapl: Use CPUID bit on AMD and Hygon parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLUaWKSjwDbUDHFO@zn.tnic>
Date:   Mon, 31 May 2021 19:18:16 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Andrew Cooper <andrew.cooper3@...rix.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, Pu Wen <puwen@...on.cn>,
        Tom Lendacky <thomas.lendacky@....com>,
        Yazen Ghannam <Yazen.Ghannam@....com>,
        Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH] perf/x86/rapl: Use CPUID bit on AMD and Hygon parts

On Fri, May 14, 2021 at 02:59:20PM +0100, Andrew Cooper wrote:
> diff --git a/arch/x86/kernel/cpu/powerflags.c b/arch/x86/kernel/cpu/powerflags.c
> index fd6ec2aa0303..e2055f51342e 100644
> --- a/arch/x86/kernel/cpu/powerflags.c
> +++ b/arch/x86/kernel/cpu/powerflags.c
> @@ -21,4 +21,6 @@ const char *const x86_power_flags[32] = {
>  	"eff_freq_ro", /* Readonly aperf/mperf */
>  	"proc_feedback", /* processor feedback interface */
>  	"acc_power", /* accumulated power mechanism */
> +	"conn_standby", /* Connected Standby */
> +	"rapl", /* Runtime Average Power Limit */

Yeah, so this repeats the "rapl" bit and that "conn_standby" is probably
not gonna be used. Unless you have a really good reason to add that
hunk, I'll whack it before applying and let this "power management"
thing in /proc/cpuinfo die unchanged.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette