linux-kernel - Re: [PATCH] sched/debug:fix stale comments of sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 May 2021 10:48:19 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Hailong Liu <liuhailongg6@....com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Vitor Massaru Iha <vitor@...saru.org>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Wei Yang <richard.weiyang@...il.com>,
        linux-kernel@...r.kernel.org, Hailong Liu <liu.hailong6@....com.cn>
Subject: Re: [PATCH] sched/debug:fix stale comments of sched_debug

On Sun, May 30, 2021 at 10:51:45AM +0800, Hailong Liu wrote:
> From: Hailong Liu <liu.hailong6@....com.cn>
> 
> Now /proc/sched_debug has been moved to debugfs, so make the comments
> consistent with it.

Have you checked if the very same Kconfig option is used for something
slightly different as well?

> Signed-off-by: Hailong Liu <liu.hailong6@....com.cn>

Missed SoB tag of the submitter.

...

> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1166,7 +1166,7 @@ config SCHED_DEBUG
>  	depends on DEBUG_KERNEL && PROC_FS

Are the dependencies correct?

>  	default y
>  	help
> -	  If you say Y here, the /proc/sched_debug file will be provided
> +	  If you say Y here, the debugfs/sched/debug file will be provided
>  	  that can help debug the scheduler. The runtime overhead of this
>  	  option is minimal.

-- 
With Best Regards,
Andy Shevchenko