linux-kernel - Re: [PATCH 0/5] RTL8231 GPIO expander support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcb95HiYxvEzYr0QXcQmA_A+2M9M0uv6PAhPHtgTges8g@mail.gmail.com>
Date:   Mon, 31 May 2021 18:48:58 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sander Vanheule <sander@...nheule.net>
Cc:     Michael Walle <michael@...le.cc>,
        Hans de Goede <hdegoede@...hat.com>,
        Andrew Lunn <andrew@...n.ch>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/5] RTL8231 GPIO expander support

On Mon, May 31, 2021 at 6:33 PM Sander Vanheule <sander@...nheule.net> wrote:
> On Mon, 2021-05-31 at 14:16 +0300, Andy Shevchenko wrote:
> > On Monday, May 31, 2021, Michael Walle <michael@...le.cc> wrote:
> > > Am 2021-05-31 10:36, schrieb Sander Vanheule:

> Am I missing something here? It seems to me like the regmap interface can't
> really accommodate what's required, unless maybe the rtl8231 regmap users
> perform some manual locking. This all seems terribly complicated compared to
> using an internal output-value cache inside regmap-gpio.

Have you had a chance to look into the PCA953x driver?
Sounds to me that you are missing the APIs that regmap provides.

-- 
With Best Regards,
Andy Shevchenko