linux-kernel - Re: [PATCH 5/6] pgo: modules Fixup memory leak.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YLUo6HrhWmeg2g1w@Ryzen-9-3900X.localdomain>
Date:   Mon, 31 May 2021 11:20:24 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Jarmo Tiitto <jarmo.tiitto@...il.com>
Cc:     samitolvanen@...gle.com, wcw@...gle.com, ndesaulniers@...gle.com,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH 5/6] pgo: modules Fixup memory leak.

On Fri, May 28, 2021 at 11:11:07PM +0300, Jarmo Tiitto wrote:
> Signed-off-by: Jarmo Tiitto <jarmo.tiitto@...il.com>

Similar comment to 6/6, squash this into 3/6.

> ---
>  kernel/pgo/fs_mod.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/pgo/fs_mod.c b/kernel/pgo/fs_mod.c
> index 0808d44227f1..2d1ff99e7982 100644
> --- a/kernel/pgo/fs_mod.c
> +++ b/kernel/pgo/fs_mod.c
> @@ -261,6 +261,8 @@ static int prf_module_open(struct inode *inode, struct file *file)
>  
>  				if (!pinfo->buffer) {
>  					err = -ENOMEM;
> +					kfree(pinfo);
> +					module_put(mod);
>  					goto out;
>  				}
>  			}
> @@ -373,7 +375,7 @@ static int pgo_module_notifier(struct notifier_block *nb, unsigned long event,
>  			if (strcmp(data->mod->name, mod->name) == 0) {
>  
>  				mutex_lock(&prf_mod_lock);
> -				/* remofe from profiled modules */
> +				/* remove from profiled modules */
>  				list_del_rcu(&data->link);
>  				/* mark it stale */
>  				WRITE_ONCE(data->mod, NULL);
> -- 
> 2.31.1