linux-kernel - Re: [PATCH v5 2/3] soc/tegra: pmc: Add core power domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4df63546-8266-3579-a3f7-e133014a4ca6@gmail.com>
Date:   Mon, 31 May 2021 23:28:09 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Peter Geis <pgwipeout@...il.com>,
        Nicolas Chauvet <kwizart@...il.com>,
        Viresh Kumar <vireshk@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Rob Herring <robh+dt@...nel.org>,
        Matt Merhar <mattmerhar@...tonmail.com>,
        Paul Fertser <fercerpav@...il.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v5 2/3] soc/tegra: pmc: Add core power domain

31.05.2021 15:36, Thierry Reding пишет:
> On Mon, May 17, 2021 at 02:17:54AM +0300, Dmitry Osipenko wrote:
>> NVIDIA Tegra SoCs have multiple power domains, each domain corresponds
>> to an external SoC power rail. Core power domain covers vast majority of
>> hardware blocks within a Tegra SoC. The voltage of a power domain should
>> be set to a level which satisfies all devices within the power domain.
>> Add support for the core power domain which controls voltage state of the
>> domain. This allows us to support system-wide DVFS on Tegra20-210 SoCs.
>> The PMC powergate domains now are sub-domains of the core domain, this
>> requires device-tree updating, older DTBs are unaffected.
>>
>> Tested-by: Peter Geis <pgwipeout@...il.com> # Ouya T30
>> Tested-by: Paul Fertser <fercerpav@...il.com> # PAZ00 T20
>> Tested-by: Nicolas Chauvet <kwizart@...il.com> # PAZ00 T20 and TK1 T124
>> Tested-by: Matt Merhar <mattmerhar@...tonmail.com> # Ouya T30
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  drivers/soc/tegra/Kconfig  |  14 ++++
>>  drivers/soc/tegra/pmc.c    | 143 +++++++++++++++++++++++++++++++++++++
>>  include/soc/tegra/common.h |   6 ++
>>  3 files changed, 163 insertions(+)
> 
> Since this power domain code is all dealt with within the PMC driver,
> and the PMC driver is enabled on all platforms, how about if we avoid
> creating the additional SOC_TEGRA_COMMON kconfig option and instead
> make SOC_TEGRA_PMC list the dependencies?
> 
> No need to resend, I can make that change when I apply, if you agree.

This can be done. I'll send v6 with the fixed compile-testing anyways,
so will apply this change there too.

The most recent version of this patch is found in [1]. Sorry for sending
so many versions and creating confusion, I settled on a unified series
that takes all build dependencies into account.

[1] https://patchwork.ozlabs.org/project/linux-tegra/list/?series=246158

Thank you for the review.