lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210531204700.GA19694@amd>
Date:   Mon, 31 May 2021 22:47:00 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Anirudh Rayabharam <mail@...rudhrb.com>,
        Kangjie Lu <kjlu@....edu>, Kalle Valo <kvalo@...eaurora.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.4 07/16] ath6kl: return error code in
 ath6kl_wmi_set_roam_lrssi_cmd()

Hi!

> From: Anirudh Rayabharam <mail@...rudhrb.com>
> 
> [ Upstream commit fc6a6521556c8250e356ddc6a3f2391aa62dc976 ]
> 
> ath6kl_wmi_cmd_send could fail, so let's return its error code
> upstream.

Something went very wrong here.

Content is okay, but "upstream commit" label is wrong, pointing to
incomplete fix that was reverted (with different content and different
author).

commit fc6a6521556c8250e356ddc6a3f2391aa62dc976
Author: Kangjie Lu <kjlu@....edu>
Date:   Wed Dec 26 00:43:28 2018 -0600

    ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd()

    ath6kl_wmi_cmd_send could fail, so let's return its error code
        upstream.

    Signed-off-by: Kangjie Lu <kjlu@....edu>
        Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Best regards,
							Pavel
							
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ