linux-kernel - Re: [PATCH 1/1] EDAC, mpc85xx: Fix error return code in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <daec460d-754c-d904-f81c-91bdfaccefad@huawei.com>
Date:   Mon, 31 May 2021 17:15:54 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     Johannes Thumshirn <morbidrsa@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        Doug Thompson <dougthompson@...ssion.com>,
        Dave Jiang <djiang@...sta.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-edac <linux-edac@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] EDAC, mpc85xx: Fix error return code in two functions



On 2021/5/31 16:40, Borislav Petkov wrote:
> On Fri, May 28, 2021 at 11:26:37AM +0800, Zhen Lei wrote:
>> Fix to return -EFAULT from the error handling case instead of 0, as done
>> elsewhere in its function.
>>
>> Fixes: a9a753d53204 ("drivers-edac: add freescale mpc85xx driver")
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
>> ---
>>  drivers/edac/mpc85xx_edac.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
>> index 67f7bc3fe5b3..b2eaa62c9412 100644
>> --- a/drivers/edac/mpc85xx_edac.c
>> +++ b/drivers/edac/mpc85xx_edac.c
>> @@ -248,6 +248,7 @@ static int mpc85xx_pci_err_probe(struct platform_device *op)
>>  
>>  	if (edac_pci_add_device(pci, pdata->edac_idx) > 0) {
>>  		edac_dbg(3, "failed edac_pci_add_device()\n");
>> +		res = -EFAULT;
> 
>>  		goto err;
>>  	}
>>  
>> @@ -552,6 +553,7 @@ static int mpc85xx_l2_err_probe(struct platform_device *op)
>>  
>>  	if (edac_device_add_device(edac_dev) > 0) {
>>  		edac_dbg(3, "failed edac_device_add_device()\n");
>> +		res = -EFAULT;
>>  		goto err;
>>  	}
>>  
>> -- 
> 
> EFAULT means
> 
> #define EFAULT          14      /* Bad address */
> 
> Does it make sense to you when the probe function returns a "bad
> address" upon failure to add a device?
> 
> hint 1: you might wanna audit how the other drivers are calling this for
> better ideas.

So how about change to -ENODEV?

> 
> hint 2: while doing hint 1, you might find some more broken cases which
> you could fix too.

OK, I will find and fix all of them. Thanks for your hint.

> 
> Thx.
>