linux-kernel - [PATCH v2 0/3] media: fix zero-length USB control requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210531094434.12651-1-johan@kernel.org>
Date:   Mon, 31 May 2021 11:44:31 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Eero Lehtinen <debiangamer2@...il.com>,
        Johan Hovold <johan@...nel.org>
Subject: [PATCH v2 0/3] media: fix zero-length USB control requests

The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.
    
Control transfers without a data stage are treated as OUT requests by
the USB stack and should be using usb_sndctrlpipe(). Failing to do so
will now trigger a warning.

This series fixes the three media drivers that got this wrong.

Johan

Changes in v2
 - keep the rtl28xxu zero-length read request which is needed for
   proper type detection (Eero)


Johan Hovold (3):
  media: gspca/gl860: fix zero-length control requests
  media: gspca/sunplus: fix zero-length control requests
  media: rtl28xxu: fix zero-length control request

 drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 11 ++++++++++-
 drivers/media/usb/gspca/gl860/gl860.c   |  4 ++--
 drivers/media/usb/gspca/sunplus.c       |  8 ++++++--
 3 files changed, 18 insertions(+), 5 deletions(-)

-- 
2.31.1