linux-kernel - Re: [PATCH v1 1/2] mmc: mmc_spi: Drop duplicate 'mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFp1ziD7w9xp789XtTvhURKTuDUyCZSzMJ5As7Y8Pq0SNQ@mail.gmail.com>
Date:   Mon, 31 May 2021 12:16:29 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/2] mmc: mmc_spi: Drop duplicate 'mmc_spi' in the
 debug messages

On Fri, 28 May 2021 at 13:21, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> dev_dbg() in any case prints the device and driver name, no need
> to repeat this in (some) messages. Drop duplicates for good.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mmc_spi.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 9776a03a10f5..65c65bb5737f 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -504,7 +504,7 @@ mmc_spi_command_send(struct mmc_spi_host *host,
>                 /* else:  R1 (most commands) */
>         }
>
> -       dev_dbg(&host->spi->dev, "  mmc_spi: CMD%d, resp %s\n",
> +       dev_dbg(&host->spi->dev, "  CMD%d, resp %s\n",
>                 cmd->opcode, maptype(cmd));
>
>         /* send command, leaving chipselect active */
> @@ -928,8 +928,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd,
>                 while (length) {
>                         t->len = min(length, blk_size);
>
> -                       dev_dbg(&host->spi->dev,
> -                               "    mmc_spi: %s block, %d bytes\n",
> +                       dev_dbg(&host->spi->dev, "    %s block, %d bytes\n",
>                                 (direction == DMA_TO_DEVICE) ? "write" : "read",
>                                 t->len);
>
> @@ -974,7 +973,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd,
>                 int             tmp;
>                 const unsigned  statlen = sizeof(scratch->status);
>
> -               dev_dbg(&spi->dev, "    mmc_spi: STOP_TRAN\n");
> +               dev_dbg(&spi->dev, "    STOP_TRAN\n");
>
>                 /* Tweak the per-block message we set up earlier by morphing
>                  * it to hold single buffer with the token followed by some
> @@ -1175,7 +1174,7 @@ static void mmc_spi_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>
>                 canpower = host->pdata && host->pdata->setpower;
>
> -               dev_dbg(&host->spi->dev, "mmc_spi: power %s (%d)%s\n",
> +               dev_dbg(&host->spi->dev, "power %s (%d)%s\n",
>                                 mmc_powerstring(ios->power_mode),
>                                 ios->vdd,
>                                 canpower ? ", can switch" : "");
> @@ -1248,8 +1247,7 @@ static void mmc_spi_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>
>                 host->spi->max_speed_hz = ios->clock;
>                 status = spi_setup(host->spi);
> -               dev_dbg(&host->spi->dev,
> -                       "mmc_spi:  clock to %d Hz, %d\n",
> +               dev_dbg(&host->spi->dev, "  clock to %d Hz, %d\n",
>                         host->spi->max_speed_hz, status);
>         }
>  }
> --
> 2.30.2
>