linux-kernel - Re: [PATCH] arm64: dts: ipq8074: disable USB phy by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92bd27423bbec56881c47eea6c382f42@codeaurora.org>
Date:   Mon, 31 May 2021 17:42:08 +0530
From:   Kathiravan T <kathirav@...eaurora.org>
To:     Robert Marko <robimarko@...il.com>
Cc:     agross@...nel.org, bjorn.andersson@...aro.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: ipq8074: disable USB phy by default

On 2021-05-26 20:31, Robert Marko wrote:
> One of the QUSB USB PHY-s has been left enabled by
> default, this is probably just a mistake as other
> USB PHY-s are disabled by default.
> 
> It makes no sense to have it enabled by default as
> not all board implement USB ports, so disable it.
> 
> Signed-off-by: Robert Marko <robimarko@...il.com>

Always, it is better to disable in SOC DTS and enable only in the board 
DTS files.

Reviewed-by: Kathiravan T <kathirav@...eaurora.org>

> ---
>  arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 555a107959831..20059d0f7d714 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -286,6 +286,7 @@ qusb_phy_0: phy@...00 {
>  			clock-names = "cfg_ahb", "ref";
> 
>  			resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> +			status = "disabled";
>  		};
> 
>  		qmp_pcie_phy0: phy@...00 {

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of Code Aurora Forum, hosted by The Linux Foundation