linux-kernel - Re: [PATCH 2/2] usb: typec: mux: Remove requirement for the "orientation-switch" device property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 May 2021 15:33:52 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Jun Li <jun.li@....com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] usb: typec: mux: Remove requirement for the
 "orientation-switch" device property

> > > Oh no. This patch just landed into Greg's usb-next. I'll prepare the
> > > revert. I'm sorry about this.
> > 
> > Actually, if we always need that extra (boolean) device property to identify
> > the device class when OF graph is used, 
> 
> Looks like yes, as we need a way to know if the current fwnode
> is for the target device we are looking for, to return probe
> defer correctly.
> 
> > shouldn't we just do that always
> > in fwnode_graph_devcon_match()?
> 
> This depends on if we want to limit this to be a boolean property
> (to mark this is the target fwnode), or make it to be more generic
> so user can define it in its ->match().
> 
> Now there are only 2 users of it, role switch and typec mux, both work
> as a boolean property for con_id.


OK. Let's leave to the users for now.

thanks,

-- 
heikki