[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1622442963-54095-1-git-send-email-zou_wei@huawei.com>
Date: Mon, 31 May 2021 14:36:03 +0800
From: Zou Wei <zou_wei@...wei.com>
To: <vkoul@...nel.org>, <yoshihiro.shimoda.uh@...esas.com>,
<geert+renesas@...der.be>, <wsa+renesas@...g-engineering.com>,
<laurent.pinchart@...asonboard.com>, <robin.murphy@....com>
CC: <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Zou Wei <zou_wei@...wei.com>
Subject: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Zou Wei <zou_wei@...wei.com>
---
drivers/dma/sh/rcar-dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index d530c1b..6885b3d 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1913,7 +1913,7 @@ static int rcar_dmac_probe(struct platform_device *pdev)
/* Enable runtime PM and initialize the device. */
pm_runtime_enable(&pdev->dev);
- ret = pm_runtime_get_sync(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0) {
dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret);
return ret;
--
2.6.2
Powered by blists - more mailing lists