linux-kernel - Re: [PATCH v2 1/2] dt-bindings: pci: Add DT bindings for apple,pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210601203314.GA977583@robh.at.kernel.org>
Date:   Tue, 1 Jun 2021 15:33:14 -0500
From:   Rob Herring <robh@...nel.org>
To:     Mark Kettenis <mark.kettenis@...all.nl>
Cc:     linux-pci@...r.kernel.org, Hector Martin <marcan@...can.st>,
        robin.murphy@....com, devicetree@...r.kernel.org,
        Mark Kettenis <kettenis@...nbsd.org>, maz@...nel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pci: Add DT bindings for apple,pcie

On Tue, Jun 01, 2021 at 08:32:10AM -0500, Rob Herring wrote:
> On Mon, 31 May 2021 00:44:00 +0200, Mark Kettenis wrote:
> > From: Mark Kettenis <kettenis@...nbsd.org>
> > 
> > The Apple PCIe host controller is a PCIe host controller with
> > multiple root ports present in Apple ARM SoC platforms, including
> > various iPhone and iPad devices and the "Apple Silicon" Macs.
> > 
> > Signed-off-by: Mark Kettenis <kettenis@...nbsd.org>
> > ---
> >  .../devicetree/bindings/pci/apple,pcie.yaml   | 167 ++++++++++++++++++
> >  MAINTAINERS                                   |   1 +
> >  2 files changed, 168 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pci/apple,pcie.yaml
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/pci/apple,pcie.example.dts:20:18: fatal error: dt-bindings/pinctrl/apple.h: No such file or directory
>    20 |         #include <dt-bindings/pinctrl/apple.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Looking at the example, I don't think you need this header. Looks like 
irq.h is needed though.

Otherwise, LGTM.

Rob