[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87v96x8bh8.fsf@meer.lwn.net>
Date: Tue, 01 Jun 2021 16:29:55 -0600
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
Linux Doc Mailing List <linux-doc@...r.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
linux-kernel@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH 0/2] Fix some issues at scripts/sphinx-pre-install
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:
> Currently, when using with --no-virtualenv, the script doesn't behave well,
> as it prints both instructions to install Sphinx via distribution's package
> manager and via pip.
>
> Address it.
>
> While here, rework the logic which recommends Sphinx install, by
> splitting it into three parts and making easier to maintain it, as
> there are too much complexity there. Splitting the Sphinx part
> of the logic on 3 separate functions allow to detect if the venv/virtualenv
> python packages are needed or not, and helps to have a cleaner
> logic.
>
> Mauro Carvalho Chehab (2):
> scripts: sphinx-pre-install: rework the sphinx install logic
> scripts: sphinx-pre-install: fix the need of virtenv packages
>
> scripts/sphinx-pre-install | 262 +++++++++++++++++++++++++------------
> 1 file changed, 180 insertions(+), 82 deletions(-)
I've applied this set, thanks.
jon
Powered by blists - more mailing lists