linux-kernel - [PATCH v1 2/2] soc/tegra: pmc: Remove usage of lockdep_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed,  2 Jun 2021 02:10:03 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: [PATCH v1 2/2] soc/tegra: pmc: Remove usage of lockdep_set_class()

The lockdep_set_class() will become necessary only if we will have a
nested toggling of core / PMC power domains that will happen if we will
add RPM and OPP support to Tegra CCF driver. Ulf Hansson has concerns
about whether this is the best approach. He suggested to remove the
lockdep class annotation until we will agree on how the OPP support of
clocks should be implemented, hence remove it for now.

Suggested-by: Ulf Hansson <ulf.hansson@...aro.org>
Signed-off-by: Dmitry Osipenko <digetx@...il.com>
---
 drivers/soc/tegra/pmc.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index d317532130c3..ea62f84d1c8b 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -1344,7 +1344,6 @@ tegra_pmc_core_pd_opp_to_performance_state(struct generic_pm_domain *genpd,
 
 static int tegra_pmc_core_pd_add(struct tegra_pmc *pmc, struct device_node *np)
 {
-	static struct lock_class_key tegra_core_domain_lock_class;
 	struct generic_pm_domain *genpd;
 	const char *rname = "core";
 	int err;
@@ -1368,15 +1367,6 @@ static int tegra_pmc_core_pd_add(struct tegra_pmc *pmc, struct device_node *np)
 		return err;
 	}
 
-	/*
-	 * We have a "PMC pwrgate -> Core" hierarchy of the power domains
-	 * where PMC needs to resume and change performance (voltage) of the
-	 * Core domain from the PMC GENPD on/off callbacks, hence we need
-	 * to annotate the lock in order to remove confusion from the
-	 * lockdep checker when a nested access happens.
-	 */
-	lockdep_set_class(&genpd->mlock, &tegra_core_domain_lock_class);
-
 	err = of_genpd_add_provider_simple(np, genpd);
 	if (err) {
 		dev_err(pmc->dev, "failed to add core genpd: %d\n", err);
-- 
2.30.2