linux-kernel - Re: [PATCH] sched/debug:fix stale comments of sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLXoQzcUwSO775Z6@hirez.programming.kicks-ass.net>
Date:   Tue, 1 Jun 2021 09:56:51 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Hailong Liu <liuhailongg6@....com>, Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Vitor Massaru Iha <vitor@...saru.org>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Wei Yang <richard.weiyang@...il.com>,
        linux-kernel@...r.kernel.org, Hailong Liu <liu.hailong6@....com.cn>
Subject: Re: [PATCH] sched/debug:fix stale comments of sched_debug

On Mon, May 31, 2021 at 07:05:22PM +0300, Andy Shevchenko wrote:
> > >> --- a/lib/Kconfig.debug
> > >> +++ b/lib/Kconfig.debug
> > >> @@ -1166,7 +1166,7 @@ config SCHED_DEBUG
> > >>  	depends on DEBUG_KERNEL && PROC_FS
> > > 
> > > Are the dependencies correct?
> > 
> > Based on your suggestion, I checked and it turned out that PROC_FS is not
> > the correct dependency, but DEBUG_FS. 
> 
> I guess you missed something.
> 
> > Shoud I change it to DEBUG_FS?
> 
> Please, double check.

Thing is that proc_sched_show_task() still wants PROC_FS, i've not yet
found a suitable debugfs based location for that.

And DEBUG_FS doesn't need a dependency; it has complete DEBUG_FS=n
wrappers and will build fine. Arguably selecting SCHED_DEBUG without
DEBUG_FS is daft, but it should work.