linux-kernel - Re: [PATCH] scsi: libsas: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <287b6910-17e8-9ef7-0042-9b525259967e@huawei.com>
Date:   Tue, 1 Jun 2021 09:16:49 +0100
From:   John Garry <john.garry@...wei.com>
To:     Wei Ming Chen <jj251510319013@...il.com>,
        <linux-kernel@...r.kernel.org>
CC:     <linux-scsi@...r.kernel.org>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>,
        "Gustavo A. R. Silva" <gustavo@...eddeodr.com>
Subject: Re: [PATCH] scsi: libsas: Use fallthrough pseudo-keyword

+ Gustavo

On 31/05/2021 16:37, Wei Ming Chen wrote:
> Replace /* Fall through */ comment with pseudo-keyword macro fallthrough[1]
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Wei Ming Chen <jj251510319013@...il.com>
> ---
>   drivers/scsi/libsas/sas_discover.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
> index 9f5068f3bcfb..dd205414e505 100644
> --- a/drivers/scsi/libsas/sas_discover.c
> +++ b/drivers/scsi/libsas/sas_discover.c
> @@ -461,7 +461,7 @@ static void sas_discover_domain(struct work_struct *work)
>   		break;
>   #else
>   		pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
> -		/* Fall through */
> +		fallthrough;

I don't know why we need the 2nd fall through (and the compiler can't 
see the first one) - added by Gustavo in da1fb2909 - but I think that 
this one can now simply be removed.

>   #endif
>   		/* Fall through - only for the #else condition above. */
Thanks,
John

>   	default:
>