linux-kernel - Re: [PATCH -next] powerpc/spufs: disp: Remove set but not used variable 'dummy'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2w3iHR8LM12MF9OtXeJiREtuQuALBEmUCyHgZxSXnczA@mail.gmail.com>
Date:   Tue, 1 Jun 2021 10:46:43 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baokun Li <libaokun1@...wei.com>
Cc:     Jeremy Kerr <jk@...abs.org>, Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        YueHaibing <yuehaibing@...wei.com>, yangjihong1@...wei.com,
        Yu Kuai <yukuai3@...wei.com>
Subject: Re: [PATCH -next] powerpc/spufs: disp: Remove set but not used
 variable 'dummy'

On Tue, Jun 1, 2021 at 10:43 AM Baokun Li <libaokun1@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> arch/powerpc/platforms/cell/spufs/switch.c: In function 'check_ppu_mb_stat':
> arch/powerpc/platforms/cell/spufs/switch.c:1660:6: warning:
> variable ‘dummy’ set but not used [-Wunused-but-set-variable]
>
> arch/powerpc/platforms/cell/spufs/switch.c: In function 'check_ppuint_mb_stat':
> arch/powerpc/platforms/cell/spufs/switch.c:1675:6: warning:
> variable ‘dummy’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>

I think in_be64() used to cause a different warning if the result was
ignored, but this is no longer the case.

Acked-by: Arnd Bergmann <arnd@...db.de>