linux-kernel - Re: [PATCH] vdpa: fix error return in vp_vdpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210601102840.GC215954@mtl-vdi-166.wap.labs.mlnx>
Date:   Tue, 1 Jun 2021 13:28:40 +0300
From:   Eli Cohen <elic@...dia.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
CC:     <mst@...hat.com>, <jasowang@...hat.com>, <sgarzare@...hat.com>,
        <virtualization@...ts.linux-foundation.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vdpa: fix error return in vp_vdpa_probe()

On Tue, Jun 01, 2021 at 04:05:05PM +0800, Jing Xiangfeng wrote:
> Fix to return error code '-ENOMEM' from the error handling case instead
> of 0.
> 
> Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>

Reviewed-by: Eli Cohen <elic@...dia.com>

> ---
>  drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index c76ebb531212..e5d92db728d3 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  			vp_modern_map_vq_notify(mdev, i,
>  						&vp_vdpa->vring[i].notify_pa);
>  		if (!vp_vdpa->vring[i].notify) {
> +			ret = -ENOMEM;
>  			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
>  			goto err;
>  		}
> -- 
> 2.26.0.106.g9fadedd
>