linux-kernel - Re: [PATCH 00/13] ARM: dts: stm32: fix "make dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5a76fa8-fac5-556d-f272-4c471f3e7913@foss.st.com>
Date:   Tue, 1 Jun 2021 12:37:10 +0200
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     <arnd@...db.de>, <robh+dt@...nel.org>, Marek Vasut <marex@...x.de>,
        <jagan@...rulasolutions.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Marcin Sloniewski <marcin.sloniewski@...il.com>,
        Ahmad Fatoum <a.fatoum@...gutronix.de>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-kernel@...r.kernel.org>, Lee Jones <lee.jones@...aro.org>,
        <kuba@...nel.org>
Subject: Re: [PATCH 00/13] ARM: dts: stm32: fix "make dtbs_check W=1" round1

Hi

On 4/15/21 12:10 PM, Alexandre Torgue wrote:
> Hi,
> 
> First round to cleanup warnings and yaml validation issues seen running
> "make dtbs_check W=1" command for STM32 platform. It concerns all SoC
> (MCU: f429/429, f746/769, h743, MPU) and all boards (ST reference boards,
> DH, Engicam, LxA ...).
> 
> Main fixes are done in device tree files but some imply a change in yaml
> dt-bindings file.
> 
> regards
> Alex
> 
> Alexandre Torgue (13):
>    ARM: dts: stm32: fix gpio-keys node on STM32 MCU boards
>    ARM: dts: stm32: fix RCC node name on stm32f429 MCU
>    ARM: dts: stm32: fix timer nodes on STM32 MCU to prevent warnings
>    dt-bindings: mfd: stm32-timers: remove #address/size cells from
>      required properties
>    ARM: dts: stm32: update pinctrl node name on STM32 MCU to prevent
>      warnings
>    ARM: dts: stm32: fix i2c node name on stm32f746 to prevent warnings
>    ARM: dts: stm32: move stmmac axi config in ethernet node on stm32mp15
>    dt-bindings: net: document ptp_ref clk in dwmac
>    ARM: dts: stm32: fix stpmic node for stm32mp1 boards
>    dt-bindings: mfd: add vref_ddr-supply to st,stpmic1 yaml
>    ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU
>    ARM: dts: stm32: fix DSI port node on STM32MP15
>    ARM: dts: stm32: fix ltdc pinctrl on microdev2.0-of7
> 
>   .../bindings/mfd/st,stm32-timers.yaml         |  2 -
>   .../devicetree/bindings/mfd/st,stpmic1.yaml   |  2 +-
>   .../devicetree/bindings/net/snps,dwmac.yaml   |  4 +-
>   .../devicetree/bindings/net/stm32-dwmac.yaml  |  6 +-
>   arch/arm/boot/dts/stm32429i-eval.dts          |  8 +-
>   arch/arm/boot/dts/stm32746g-eval.dts          |  6 +-
>   arch/arm/boot/dts/stm32f4-pinctrl.dtsi        |  2 +-
>   arch/arm/boot/dts/stm32f429-disco.dts         |  6 +-
>   arch/arm/boot/dts/stm32f429-pinctrl.dtsi      | 72 +++++++++---------
>   arch/arm/boot/dts/stm32f429.dtsi              | 10 +--
>   arch/arm/boot/dts/stm32f469-disco.dts         |  8 +-
>   arch/arm/boot/dts/stm32f469-pinctrl.dtsi      | 74 +++++++++----------
>   arch/arm/boot/dts/stm32f7-pinctrl.dtsi        |  2 +-
>   arch/arm/boot/dts/stm32f746.dtsi              | 12 +--
>   arch/arm/boot/dts/stm32f769-disco.dts         |  6 +-
>   arch/arm/boot/dts/stm32h743.dtsi              |  4 -
>   arch/arm/boot/dts/stm32mp151.dtsi             | 16 ++--
>   arch/arm/boot/dts/stm32mp157.dtsi             |  2 -
>   arch/arm/boot/dts/stm32mp157a-dk1.dts         |  8 ++
>   ...157a-microgea-stm32mp1-microdev2.0-of7.dts |  5 +-
>   arch/arm/boot/dts/stm32mp157a-stinger96.dtsi  |  7 +-
>   arch/arm/boot/dts/stm32mp157c-dk2.dts         | 12 ++-
>   arch/arm/boot/dts/stm32mp157c-ev1.dts         |  5 +-
>   arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts     |  3 +-
>   .../arm/boot/dts/stm32mp157c-odyssey-som.dtsi |  5 +-
>   arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi  |  5 +-
>   .../boot/dts/stm32mp15xx-dhcor-avenger96.dtsi |  6 +-
>   arch/arm/boot/dts/stm32mp15xx-dkx.dtsi        |  7 --
>   arch/arm/boot/dts/stm32mp15xx-osd32.dtsi      |  7 +-
>   29 files changed, 130 insertions(+), 182 deletions(-)
> 

Patches 1 to 8 and 13 applied on stm32-next. I will send a v2 for 
vref-ddr supply. There is still an open point about #adress-size/cells 
check for DSI / LTDC ports.

Rob,
Can we consider to have "#adress-size/cells defined even if only one 
endpoint (child) is defined ? and then is it possible to update the 
checker ? Or do we have to keep patches [11][12]
and update #adress-size/cells in board dts files ?

Thanks
Alex