| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Jun 2021 18:45:28 +0800
From: kernel test robot <lkp@...el.com>
To: cy_huang <u0084500@...il.com>, lgirdwood@...il.com,
broonie@...nel.org, robh+dt@...nel.org
Cc: kbuild-all@...ts.01.org, cy_huang@...htek.com,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 2/2] regulator: rt6160: Add support for Richtek RT6160
Hi cy_huang,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on regulator/for-next]
[also build test WARNING on v5.13-rc4 next-20210601]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/cy_huang/regulator-rt6160-Add-DT-binding-document-for-Richtek-RT6160/20210601-143438
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f3badc2fd9e7db2b077313371d7b408291a1bb3f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review cy_huang/regulator-rt6160-Add-DT-binding-document-for-Richtek-RT6160/20210601-143438
git checkout f3badc2fd9e7db2b077313371d7b408291a1bb3f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/acpi.h:15,
from include/linux/i2c.h:13,
from drivers/regulator/rt6160-regulator.c:5:
drivers/regulator/rt6160-regulator.c: In function 'rt6160_probe':
>> drivers/regulator/rt6160-regulator.c:269:22: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
269 | dev_err(&i2c->dev, "Failed to init regmap (%d)\n", PTR_ERR(priv->regmap));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/regulator/rt6160-regulator.c:269:3: note: in expansion of macro 'dev_err'
269 | dev_err(&i2c->dev, "Failed to init regmap (%d)\n", PTR_ERR(priv->regmap));
| ^~~~~~~
drivers/regulator/rt6160-regulator.c:269:47: note: format string is defined here
269 | dev_err(&i2c->dev, "Failed to init regmap (%d)\n", PTR_ERR(priv->regmap));
| ~^
| |
| int
| %ld
vim +269 drivers/regulator/rt6160-regulator.c
243
244 static int rt6160_probe(struct i2c_client *i2c)
245 {
246 struct rt6160_priv *priv;
247 struct regulator_config regulator_cfg = {};
248 struct regulator_dev *rdev;
249 unsigned int devid;
250 int ret;
251
252 priv = devm_kzalloc(&i2c->dev, sizeof(*priv), GFP_KERNEL);
253 if (!priv)
254 return -ENOMEM;
255
256 priv->vsel_active_low = device_property_present(&i2c->dev, "richtek,vsel-active-low");
257
258 priv->enable_gpio = devm_gpiod_get_optional(&i2c->dev, "enable", GPIOD_OUT_HIGH);
259 if (IS_ERR(priv->enable_gpio)) {
260 dev_err(&i2c->dev, "Failed to get 'enable' gpio\n");
261 return PTR_ERR(priv->enable_gpio);
262 }
263 priv->enable_state = true;
264
265 usleep_range(RT6160_I2CRDY_TIMEUS, RT6160_I2CRDY_TIMEUS + 100);
266
267 priv->regmap = devm_regmap_init_i2c(i2c, &rt6160_regmap_config);
268 if (IS_ERR(priv->regmap)) {
> 269 dev_err(&i2c->dev, "Failed to init regmap (%d)\n", PTR_ERR(priv->regmap));
270 return PTR_ERR(priv->regmap);
271 }
272
273 ret = regmap_read(priv->regmap, RT6160_REG_DEVID, &devid);
274 if (ret)
275 return ret;
276
277 if ((devid & RT6160_VID_MASK) != RT6160_VENDOR_ID) {
278 dev_err(&i2c->dev, "VID not correct [0x%02x]\n", devid);
279 return -ENODEV;
280 }
281
282 priv->desc.name = "rt6160-buckboost";
283 priv->desc.type = REGULATOR_VOLTAGE;
284 priv->desc.owner = THIS_MODULE;
285 priv->desc.min_uV = RT6160_VOUT_MINUV;
286 priv->desc.uV_step = RT6160_VOUT_STPUV;
287 priv->desc.vsel_reg = RT6160_REG_VSELH;
288 priv->desc.vsel_mask = RT6160_VSEL_MASK;
289 priv->desc.n_voltages = RT6160_N_VOUTS;
290 priv->desc.of_map_mode = rt6160_of_map_mode;
291 priv->desc.ops = &rt6160_regulator_ops;
292 if (priv->vsel_active_low)
293 priv->desc.vsel_reg = RT6160_REG_VSELL;
294
295 regulator_cfg.dev = &i2c->dev;
296 regulator_cfg.of_node = i2c->dev.of_node;
297 regulator_cfg.regmap = priv->regmap;
298 regulator_cfg.driver_data = priv;
299 regulator_cfg.init_data = of_get_regulator_init_data(&i2c->dev, i2c->dev.of_node,
300 &priv->desc);
301
302 rdev = devm_regulator_register(&i2c->dev, &priv->desc, ®ulator_cfg);
303 if (IS_ERR(rdev)) {
304 dev_err(&i2c->dev, "Failed to register regulator\n");
305 return PTR_ERR(rdev);
306 }
307
308 return 0;
309 }
310
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (64431 bytes)
Powered by blists - more mailing lists