linux-kernel - re: scsi: mpt3sas: Handle firmware faults during second half of IOC init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 1 Jun 2021 12:41:35 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Suganath Prabu S <suganath-prabu.subramani@...adcom.com>,
        Sathya Prakash <sathya.prakash@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        MPT-FusionLinux.pdl@...adcom.com,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: re: scsi: mpt3sas: Handle firmware faults during second half of IOC
 init

Hi,

Static analysis with Coverity on linux-next has detected an issue in
drivers/scsi/mpt3sas/mpt3sas_base.c with the following commit:

commit a0815c45c89f544861eae55d85ccee6b1b1451e8
Author: Suganath Prabu S <suganath-prabu.subramani@...adcom.com>
Date:   Tue May 18 10:46:25 2021 +0530

    scsi: mpt3sas: Handle firmware faults during second half of IOC init

The analysis is as follows:

7208        if (ioc->port_enable_cmds.status & MPT3_CMD_COMPLETE_ASYNC) {
7209                if (ioc_status == MPI2_IOCSTATUS_SUCCESS) {
7210                        mpt3sas_port_enable_complete(ioc);
7211                        return 1;
7212                } else {
7213                        ioc->start_scan_failed = ioc_status;
7214                        ioc->start_scan = 0;
7215                        return 1;
7216                }

Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached:

7217                ioc->port_enable_cmds.status &=
~MPT3_CMD_COMPLETE_ASYNC;
7218        }

The return 1 statements in either parts of the proceeding if statement
end up with the ioc->port_enable_cmds.status masking assignment never
being reached.

Colin