linux-kernel - The value of FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3baupJJ7Q9otxtoQ-DH5e-J2isg-LZj2CsOqRPo70AL4A@mail.gmail.com>
Date:   Tue, 1 Jun 2021 22:18:29 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     jmaloy@...hat.com
Cc:     ying.xue@...driver.com, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, etdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net,
        LKML <linux-kernel@...r.kernel.org>
Subject: The value of FB_MTU eats two pages

Hello!

I have a question about the value of FB_MTU in tipc, how does the '3744' form?
I notice that it is used in 'tipc_msg_build()' when memory allocation
fails, and it
tries to fall back to a smaller MTU to avoid unnecessary sending failures.

However, the size of the data allocated will be more than 4096 when FB_MTU
is 3744. I did a rough calculation, the size of data will more than 4200:

(FB_MTU + TIPCHDR + BUF_HEADROOM + sizeof(struct skb_shared_info))

Therefore, 8192 will be allocated from slab, and about 4000 of it will
not be used.

FB_MTU is used for low memory, and I think eating two pages will make it worse.
Do I miss something?

Thanks!
Menglong Dong