[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210601145540.GM543307@dell>
Date: Tue, 1 Jun 2021 15:55:40 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Tony Lindgren <tony@...mide.com>
Cc: linux-kernel@...r.kernel.org,
Carl Philipp Klemm <philipp@...s.xyz>,
Ivan Jelincic <parazyd@...e.org>,
Merlijn Wajer <merlijn@...zup.org>,
Pavel Machek <pavel@....cz>,
Sebastian Reichel <sre@...nel.org>,
"Sicelo A . Mhlongo" <absicsz@...il.com>
Subject: Re: [PATCH] mfd: cpcap: Fix cpcap dmamask not set warnings
On Sat, 22 May 2021, Tony Lindgren wrote:
> We have started to get a bunch of pointless dmamask not set warnings
> that makes the output of dmesg -l err,warn hard to read with many
> extra warnings:
>
> cpcap-regulator cpcap-regulator.0: DMA mask not set
> cpcap_adc cpcap_adc.0: DMA mask not set
> cpcap_battery cpcap_battery.0: DMA mask not set
> cpcap-charger cpcap-charger.0: DMA mask not set
> cpcap-pwrbutton cpcap-pwrbutton.0: DMA mask not set
> cpcap-led cpcap-led.0: DMA mask not set
> cpcap-led cpcap-led.1: DMA mask not set
> cpcap-led cpcap-led.2: DMA mask not set
> cpcap-led cpcap-led.3: DMA mask not set
> cpcap-led cpcap-led.4: DMA mask not set
> cpcap-rtc cpcap-rtc.0: DMA mask not set
> cpcap-usb-phy cpcap-usb-phy.0: DMA mask not set
>
> This seems to have started with commit 4d8bde883bfb ("OF: Don't set
> default coherent DMA mask"). We have the parent SPI controller use
> DMA, while CPCAP driver and it's children do not. For audio, the
> DMA is handled over I2S bus with the McBSP driver.
>
> Cc: Carl Philipp Klemm <philipp@...s.xyz>
> Cc: Ivan Jelincic <parazyd@...e.org>
> Cc: Merlijn Wajer <merlijn@...zup.org>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Sicelo A. Mhlongo <absicsz@...il.com>
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---
> drivers/mfd/motorola-cpcap.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists