linux-kernel - Re: [PATCH] fs/jfs: Fix missing error code in lmLogInit()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <103f7053-409a-72c6-aae2-613d80b521d7@oracle.com>
Date:   Tue, 1 Jun 2021 10:30:49 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/jfs: Fix missing error code in lmLogInit()

Good catch. I'll push this in the next merge window.

Thanks,
Shaggy

On 6/1/21 6:07 AM, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc.
> 
> Eliminate the follow smatch warning:
> 
> fs/jfs/jfs_logmgr.c:1327 lmLogInit() warn: missing error code 'rc'.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   fs/jfs/jfs_logmgr.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 9330eff21..78fd136 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1324,6 +1324,7 @@ int lmLogInit(struct jfs_log * log)
>   		} else {
>   			if (!uuid_equal(&logsuper->uuid, &log->uuid)) {
>   				jfs_warn("wrong uuid on JFS log device");
> +				rc = -EINVAL;
>   				goto errout20;
>   			}
>   			log->size = le32_to_cpu(logsuper->size);
>