linux-kernel - Re: [PATCH] qla2xxx: Log PCI address in qla_nvme_unregister_remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd338153-1736-07c5-688c-7d2a1703579c@oracle.com>
Date:   Tue, 1 Jun 2021 10:46:40 -0500
From:   Himanshu Madhani <himanshu.madhani@...cle.com>
To:     Daniel Wagner <dwagner@...e.de>, linux-scsi@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        GR-QLogic-Storage-Upstream@...vell.com,
        Nilesh Javali <njavali@...vell.com>
Subject: Re: [PATCH] qla2xxx: Log PCI address in
 qla_nvme_unregister_remote_port()



On 5/31/21 7:24 AM, Daniel Wagner wrote:
> Pass in fcport->vha to ql_log() in order to add the PCI address to the
> log.
> 
> Currently NULL is passed in which gives this confusing log entry:
> 
>> qla2xxx [0000:00:00.0]-2112: : qla_nvme_unregister_remote_port: unregister remoteport on 0000000009d6a2e9 50000973981648c7
> 
> Signed-off-by: Daniel Wagner <dwagner@...e.de>
> ---
>   drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 0cacb667a88b..e119f8b24e33 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -671,7 +671,7 @@ void qla_nvme_unregister_remote_port(struct fc_port *fcport)
>   	if (!IS_ENABLED(CONFIG_NVME_FC))
>   		return;
>   
> -	ql_log(ql_log_warn, NULL, 0x2112,
> +	ql_log(ql_log_warn, fcport->vha, 0x2112,
>   	    "%s: unregister remoteport on %p %8phN\n",
>   	    __func__, fcport, fcport->port_name);
>   
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering