linux-kernel - Re: [PATCH v2] userfaultfd: fix UFFDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJHvVch713YnMA6KYPVret2p6yB_5+mfRJ_JbC2q2Afeh-KZbg@mail.gmail.com>
Date:   Tue, 1 Jun 2021 09:41:03 -0700
From:   Axel Rasmussen <axelrasmussen@...gle.com>
To:     Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Peter Xu <peterx@...hat.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Lokesh Gidra <lokeshgidra@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] userfaultfd: fix UFFDIO_CONTINUE ioctl request definition

Thanks for catching this!

Reviewed-by: Axel Rasmussen <axelrasmussen@...gle.com>

On Tue, Jun 1, 2021 at 7:34 AM Gleb Fotengauer-Malinovskiy
<glebfm@...linux.org> wrote:
>
> This ioctl request reads from uffdio_continue structure which justifies
> _IOC_READ flag.
> See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
>
> Fixes: f619147104c8 ("userfaultfd: add UFFDIO_CONTINUE ioctl")
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>
> Acked-by: Peter Xu <peterx@...hat.com>
> ---
>  include/uapi/linux/userfaultfd.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> v2 fix commit message
>
> diff --git a/include/uapi/linux/userfaultfd.h b/include/uapi/linux/userfaultfd.h
> index bafbeb1a2624..650480f41f1d 100644
> --- a/include/uapi/linux/userfaultfd.h
> +++ b/include/uapi/linux/userfaultfd.h
> @@ -80,8 +80,8 @@
>                                       struct uffdio_zeropage)
>  #define UFFDIO_WRITEPROTECT    _IOWR(UFFDIO, _UFFDIO_WRITEPROTECT, \
>                                       struct uffdio_writeprotect)
> -#define UFFDIO_CONTINUE                _IOR(UFFDIO, _UFFDIO_CONTINUE,  \
> -                                    struct uffdio_continue)
> +#define UFFDIO_CONTINUE                _IOWR(UFFDIO, _UFFDIO_CONTINUE, \
> +                                     struct uffdio_continue)
>
>  /* read() structure */
>  struct uffd_msg {
> --
> glebfm
>