linux-kernel - Re: [PATCH -next] soc/tegra: fuse: don't return -ENOMEM when allocate lookups failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YLZoC32dTDVwfSjh@orome.fritz.box>
Date:   Tue, 1 Jun 2021 19:02:03 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        jonathanh@...dia.com
Subject: Re: [PATCH -next] soc/tegra: fuse: don't return -ENOMEM when
 allocate lookups failed

On Mon, Apr 12, 2021 at 10:05:27PM +0800, Yang Yingliang wrote:
> fuse->base can not be unmapped if allocate lookups failed in
> tegra_init_fuse(), because it is an early_initcall, the driver
> will be loaded anyway and fuse->base will be accessed by other
> functions later, so remove the return -ENOMEM after allocating
> lookups failed to make less confusing.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)

Applied, though I did drop the error message. Out-of-memory situations
are noisy anyway, so the extra error message doesn't add anything.

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)