linux-kernel - Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5b5c871537bcc6931894e8f61ca7b28950c114a.camel@perches.com>
Date:   Wed, 02 Jun 2021 08:36:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        sh4nnu <manikishanghantasala@...il.com>
Cc:     Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix coding-style issues in
 r8192U_hw.h

On Wed, 2021-06-02 at 17:18 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 02, 2021 at 08:40:33PM +0530, sh4nnu wrote:
> > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
> > 
> > "Macros with complex values should be enclosed in parantheses"
> > by enclosing values in parantheses.

parentheses

> > Signed-off-by: sh4nnu <manikishanghantasala@...il.com>
[]
> - It looks like you did not use your "real" name for the patch on either
>   the Signed-off-by: line, or the From: line (both of which have to
>   match).  Please read the kernel file, Documentation/SubmittingPatches
>   for how to do this correctly.

Might be useful to have the patchbot script reduce the content of the
message when it's identifiable.

The patch itself looks OK.