linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Update flash freq to match reality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XqAX7o+caB-AyNkmBQNeq7iaoUgmwKknq1kXhsJCMw=w@mail.gmail.com>
Date:   Wed, 2 Jun 2021 08:51:38 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Update flash freq to
 match reality

Bjorn,

On Wed, May 19, 2021 at 9:05 AM Doug Anderson <dianders@...omium.org> wrote:
>
> Hi,
>
> On Tue, May 18, 2021 at 10:40 PM Stephen Boyd <swboyd@...omium.org> wrote:
> >
> > This spi flash part is actually being clocked at 37.5MHz, not 25MHz,
> > because of the way the clk driver is rounding up the rate that is
> > requested to the nearest supported frequency. Let's update the frequency
> > here, and remove the TODO because this is the fastest frequency we're
> > going to be able to use here.
> >
> > Cc: Douglas Anderson <dianders@...omium.org>
> > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > index 24d293ef56d7..af3c0e1e2223 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > @@ -335,8 +335,7 @@ flash@0 {
> >                 compatible = "jedec,spi-nor";
> >                 reg = <0>;
> >
> > -               /* TODO: Increase frequency after testing */
> > -               spi-max-frequency = <25000000>;
> > +               spi-max-frequency = <37500000>;
> >                 spi-tx-bus-width = <2>;
> >                 spi-rx-bus-width = <2>;
> >         };
>
> Thanks. Looks right to me. I confirmed that the clock is 150 MHz in my
> "clk_summary" which is 4x 37.5.
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>

If you agree, I think this patch is ready to land.

-Doug