linux-kernel - Re: [PATCH] i2c: bcm-iproc: Add i2c recovery support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d133a136-11c1-1693-6f9b-e6fcf6a448f6@alliedtelesis.co.nz>
Date:   Wed, 2 Jun 2021 02:32:14 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Ray Jui <ray.jui@...adcom.com>, "wsa@...nel.org" <wsa@...nel.org>,
        "rjui@...adcom.com" <rjui@...adcom.com>,
        "sbranden@...adcom.com" <sbranden@...adcom.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Richard Laing <Richard.Laing@...iedtelesis.co.nz>
Subject: Re: [PATCH] i2c: bcm-iproc: Add i2c recovery support


On 2/06/21 9:03 am, Ray Jui wrote:
>
> On 5/30/2021 3:56 PM, Chris Packham wrote:
>> From: Richard Laing <richard.laing@...iedtelesis.co.nz>
>>
>> The bcm-iproc controller can put the SDA/SCL lines into bit-bang mode,
>> make use of this to support i2c bus recovery.
>>
>> Signed-off-by: Richard Laing <richard.laing@...iedtelesis.co.nz>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
<snip>
> +
>> +static struct i2c_bus_recovery_info bcm_iproc_recovery_info = {
> static const struct ...

The kernel test bot doesn't like the suggestion.

 >> drivers/i2c/busses/i2c-bcm-iproc.c:1264:26: error: assigning to 
'struct i2c_bus_recovery_info *' from 'const struct 
i2c_bus_recovery_info *' discards qualifiers 
[-Werror,-Wincompatible-pointer-types-discards-qualifiers]

            adap->bus_recovery_info = &bcm_iproc_recovery_info;
                                    ^ ~~~~~~~~~~~~~~~~~~~~~~~~

I can see why. Are you happy for me to drop the const in v3? Or perhaps 
you have a better suggestion.