linux-kernel - Re: [PATCH] h8300: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLfWONfYC0Fw2mdL@kernel.org>
Date:   Wed, 2 Jun 2021 22:04:24 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     ysato@...rs.sourceforge.jp, akpm@...ux-foundation.org,
        sboyd@...nel.org, geert+renesas@...der.be,
        uclinux-h8-devel@...ts.sourceforge.jp,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] h8300: Remove unused variable

On Thu, Jun 03, 2021 at 12:24:31AM +0530, Souptick Joarder wrote:
> Kernel test robot throws below warning ->
> 
> >> arch/h8300/kernel/setup.c:72:26:
> warning: Unused variable: region [unusedVariable]
>     struct memblock_region *region;
> 
> Fixed it by removing unused variable.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

I believe a Fixes: tag would be appropriate here. Otherwise

Acked-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  arch/h8300/kernel/setup.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index 15280af7251c..5745a763dc78 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
>  
>  static void __init bootmem_init(void)
>  {
> -	struct memblock_region *region;
> -
>  	memory_end = memory_start = 0;
>  
>  	/* Find main memory where is the kernel */
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.