linux-kernel - Re: [PATCH v2 1/3] mm,page_alloc: Use {get,put}_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed17a39ad61edeb19b04c0f4308d5d36@suse.de>
Date:   Wed, 02 Jun 2021 21:45:58 +0200
From:   Oscar Salvador <osalvador@...e.de>
To:     David Hildenbrand <david@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Michal Hocko <mhocko@...nel.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Pavel Tatashin <pasha.tatashin@...een.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] mm,page_alloc: Use {get,put}_online_mems() to get
 stable zone's values

On 2021-06-02 20:37, David Hildenbrand wrote:
> Long story short, using get_online_mems() looks wrong.
> 
> Maybe the current lightweight reader/writer protection does serve a 
> purpose?

It was too nice and easy to be true I guess.
Yeah, I missed the point that blocking might be an issue here, and 
hotplug operations can take really long, so not an option.
I must have switched my brain off back there, because now it is just too 
obvious.

Then I guwmess that seqlock must stay and the only thing than can go is 
the pgdat resize lock from the hotplug code.

Meh.

-- 
Oscar Salvador
SUSE L3