linux-kernel - Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210602200609.GA3900200@robh.at.kernel.org>
Date:   Wed, 2 Jun 2021 15:06:09 -0500
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Mark Brown <broonie@...nel.org>,
        linux-samsung-soc@...r.kernel.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        devicetree@...r.kernel.org,
        Iskren Chernev <iskren.chernev@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-rtc@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce
 (incorrect) interrupt trigger type

On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@...nel.org>
> 
> Interrupt line can be configured on different hardware in different way,
> even inverted.  Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
> 
> The Maxim 14577/77836 datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Acked-by: Iskren Chernev <iskren.chernev@...il.com>
> 
> ---
> 
> Changes since v1:
> 1. Remove the 'flags' variable.
> 2. Added ack.
> 3. Rebase - the bindings were converted to dtschema.
> ---
>  .../devicetree/bindings/power/supply/maxim,max17040.yaml      | 2 +-
>  drivers/power/supply/max17040_battery.c                       | 4 +---
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 

Acked-by: Rob Herring <robh@...nel.org>