[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210602212241.2175005-1-namhyung@kernel.org>
Date: Wed, 2 Jun 2021 14:22:39 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>,
Jiri Olsa <jolsa@...hat.com>
Cc: Ingo Molnar <mingo@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
LKML <linux-kernel@...r.kernel.org>,
Andi Kleen <ak@...ux.intel.com>,
Ian Rogers <irogers@...gle.com>,
Jin Yao <yao.jin@...ux.intel.com>
Subject: [PATCH 1/3] perf stat: Check return value of asprintf() properly
It returns -1 on error, so checking with 0 would not work.
Fixes: 12279429d862 ("perf stat: Uniquify hybrid event name")
Cc: Jin Yao <yao.jin@...ux.intel.com>
Signed-off-by: Namhyung Kim <namhyung@...nel.org>
---
tools/perf/util/stat-display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index b759dfd633b4..04afd41b6067 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -564,7 +564,7 @@ static void uniquify_event_name(struct evsel *counter)
counter->name, counter->pmu_name);
}
- if (ret) {
+ if (ret > 0) {
free(counter->name);
counter->name = new_name;
}
--
2.32.0.rc0.204.g9fa02ecfa5-goog
Powered by blists - more mailing lists