linux-kernel - Re: [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d50f61b0-e165-b3d3-d278-ef0514ddccc0@redhat.com>
Date:   Wed, 2 Jun 2021 15:10:37 -0700
From:   Tom Rix <trix@...hat.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>, mpe@...erman.id.au,
        benh@...nel.crashing.org, paulus@...ba.org
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS


On 6/2/21 12:44 AM, Christophe Leroy wrote:
>
>
> Le 01/06/2021 à 19:53, trix@...hat.com a écrit :
>> From: Tom Rix <trix@...hat.com>
>>
>> With MPC8XXFADS, there is this linker error
>> ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade':
>> m8xx_setup.c: undefined reference to `cpm_get_irq'
>
> It looks like this config item is stale, it doesn't build any board 
> support, there is no define_machine() for this config item, no file is 
> linked to that config item.
>
> I think you should just remove that item from the possible choices.
>
Yes, this looks like a dead config and removing it is what to do.

I withdraw this change.

I am looking at sweeping the tree of dead configs.

Up a dir, my finder shows

PPC_MMU_NOHASH_32

is another (maybe) dead config.

Thanks for pointing this out,

Tom

> Christophe
>
>
>>
>> cpm_get_irq() is conditionally complied by CPM1
>> So add a select, like the other plaforms
>>
>> Signed-off-by: Tom Rix <trix@...hat.com>
>> ---
>>   arch/powerpc/platforms/8xx/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/platforms/8xx/Kconfig 
>> b/arch/powerpc/platforms/8xx/Kconfig
>> index 60cc5b537a98..919082cdb2f1 100644
>> --- a/arch/powerpc/platforms/8xx/Kconfig
>> +++ b/arch/powerpc/platforms/8xx/Kconfig
>> @@ -10,6 +10,7 @@ choice
>>     config MPC8XXFADS
>>       bool "FADS"
>> +    select CPM1
>>     config MPC86XADS
>>       bool "MPC86XADS"
>>
>