linux-kernel - Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLcF8k71w1mhN9OX@google.com>
Date:   Tue, 1 Jun 2021 21:15:46 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michael Schmitz <schmitz@...ian.org>,
        Roman Zippel <zippel@...ux-m68k.org>,
        linux-input <linux-input@...r.kernel.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Michael Schmitz <schmitzmic@...il.com>
Subject: Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning

On Thu, May 27, 2021 at 08:56:30AM +0200, Geert Uytterhoeven wrote:
> On Thu, May 27, 2021 at 2:12 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> > Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
> > code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
> > this dependency.
> >
> > Removes this kconfig warning:
> >
> > WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> >   Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> >   Selected by [y]:
> >   - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
> >
> > Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Michael Schmitz <schmitz@...ian.org>
> > Cc: Roman Zippel <zippel@...ux-m68k.org>
> > Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Cc: linux-input@...r.kernel.org
> > Cc: linux-m68k@...ts.linux-m68k.org
> > Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Suggested-by: Michael Schmitz <schmitzmic@...il.com>
> 
> > ---
> > v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
> >     to Kconfig.machine (Michael). Thanks.
> 
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees.

Sure, works for me.

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Thanks.

-- 
Dmitry