linux-kernel - Re: [PATCH V3 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLcLCmxNOYqj0SN3@google.com>
Date:   Tue, 1 Jun 2021 21:37:30 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     skakit@...eaurora.org
Cc:     Rob Herring <robh@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        kgunda@...eaurora.org, linux-pm@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Courtney Cavin <courtney.cavin@...ymobile.com>,
        Vinod Koul <vkoul@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        David Collins <collinsd@...eaurora.org>,
        Andy Yan <andy.yan@...k-chips.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        devicetree@...r.kernel.org, Andy Gross <agross@...nel.org>
Subject: Re: [PATCH V3 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941
 power key binding to yaml

On Wed, May 12, 2021 at 10:17:43AM +0530, skakit@...eaurora.org wrote:
> On 2021-05-10 21:54, Rob Herring wrote:
> > On Mon, May 10, 2021 at 09:01:39AM -0500, Rob Herring wrote:
> > > On Mon, 10 May 2021 12:31:03 +0530, satya priya wrote:
> > > > Convert qcom pm8941 power key binding from .txt to .yaml format.
> > > >
> > > > Signed-off-by: satya priya <skakit@...eaurora.org>
> > > > ---
> > > > Changes in V2:
> > > >  - Fixed bot errors, took reference from input.yaml for "linux,code"
> > > >  - Added one complete example for powerkey and resin, and referenced it
> > > >    in main PON binding.
> > > >  - Moved this patch to the end of the series.
> > > >
> > > > Changes in V3:
> > > >  - Moved this patch before PON binding patch.
> > > >  - As per Rob's comments, added allOf at the beginning of binding.
> > > >    Added maxItems for interrupts.
> > > >  - Added 'unevaluatedProperties' instead of 'additionalProperties' as
> > > >    we are using allOf.
> > > >
> > > >  .../bindings/input/qcom,pm8941-pwrkey.txt          | 55 --------------
> > > >  .../bindings/input/qcom,pm8941-pwrkey.yaml         | 87 ++++++++++++++++++++++
> > > >  2 files changed, 87 insertions(+), 55 deletions(-)
> > > >  delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
> > > >  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> > > >
> > > 
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > > dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.example.dt.yaml:0:0:
> > > /example-0/spmi@...0000/pmic@...on_hlos@...0: failed to match any
> > > schema with compatible: ['qcom,pm8998-pon']
> > 
> > You have the same example in patch 5, so drop the example here. That
> > will fix this circular dependency.
> 
> Earlier I have dropped example from qcom-pon.yaml. Now, I will add the
> example there and drop here.

It sounds to me you want to combine patches 4 and 5 since they depend on
each other.

Thanks.

-- 
Dmitry