linux-kernel - Re: [PATCH] x86/alternative: Align insn bytes vertically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLc/QIpcfjHUoOgf@hirez.programming.kicks-ass.net>
Date:   Wed, 2 Jun 2021 10:20:16 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/alternative: Align insn bytes vertically

On Tue, Jun 01, 2021 at 09:37:13PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> For easier inspection which bytes have changed.
> 
> For example:
> 
>   feat: 7*32+12, old: (__x86_indirect_thunk_r10+0x0/0x20 (ffffffff81c02480) len: 17), repl: (ffffffff897813aa, len: 17)
>   ffffffff81c02480:   old_insn: 41 ff e2 90 90 90 90 90 90 90 90 90 90 90 90 90 90
>   ffffffff897813aa:   rpl_insn: e8 07 00 00 00 f3 90 0f ae e8 eb f9 4c 89 14 24 c3
>   ffffffff81c02480: final_insn: e8 07 00 00 00 f3 90 0f ae e8 eb f9 4c 89 14 24 c3
> 
> No functional changes.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>

Nice!

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>