[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210602084935.3977636-1-yangyingliang@huawei.com>
Date: Wed, 2 Jun 2021 16:49:35 +0800
From: Yang Yingliang <yangyingliang@...wei.com>
To: <linux-kernel@...r.kernel.org>, <linux-i3c@...ts.infradead.org>
CC: <alexandre.belloni@...tlin.com>, <miquel.raynal@...tlin.com>
Subject: [PATCH -next v2] i3c: master: svc: drop free_irq of devm_request_irq allocated irq
irq allocated with devm_request_irq() will be freed in devm_irq_release(),
using free_irq() in ->remove() will causes a dangling pointer, and a
subsequent double free. So remove the free_irq() in svc_i3c_master_remove().
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
---
v2:
removing free_irq() instead of using devm_free_irq()
---
drivers/i3c/master/svc-i3c-master.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 1f6ba4221817..eeb49b5d90ef 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1448,7 +1448,6 @@ static int svc_i3c_master_remove(struct platform_device *pdev)
if (ret)
return ret;
- free_irq(master->irq, master);
clk_disable_unprepare(master->pclk);
clk_disable_unprepare(master->fclk);
clk_disable_unprepare(master->sclk);
--
2.25.1
Powered by blists - more mailing lists