linux-kernel - Re: [PATCH] ACPI: tables: fixes the missed acpi_put_table() in acpi_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b70f1c51-08fa-4ddf-51c6-77064e02fe87@huawei.com>
Date:   Wed, 2 Jun 2021 17:21:38 +0800
From:   Hanjun Guo <guohanjun@...wei.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>, <rjw@...ysocki.net>,
        <lenb@...nel.org>, <rui.zhang@...el.com>
CC:     <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: tables: fixes the missed acpi_put_table() in
 acpi_init_fpdt()

The title of this patch is misleading, how about "ACPI: FPDT: Add the
missed acpi_put_table() in acpi_init_fpdt()" ?

On 2021/6/2 9:17, Jing Xiangfeng wrote:
> acpi_init_fpdt() misses to call acpi_put_table() in an error path. Add
> the missed function call to fix it.
> 
> Fixes: d1eb86e59be0 ("ACPI: tables: introduce support for FPDT table")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
>   drivers/acpi/acpi_fpdt.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
> index a89a806a7a2a..4ee2ad234e3d 100644
> --- a/drivers/acpi/acpi_fpdt.c
> +++ b/drivers/acpi/acpi_fpdt.c
> @@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void)
>   		return 0;
>   
>   	fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj);
> -	if (!fpdt_kobj)
> +	if (!fpdt_kobj) {
> +		acpi_put_table(header);
>   		return -ENOMEM;
> +	}

The code looks good to me.

Thanks
Hanjun