linux-kernel - Re: [PATCH v2 2/4] dt-bindings: arm: scmi property mboxes is not mandatory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Jun 2021 11:40:50 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Etienne Carriere <etienne.carriere@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Cristian Marussi <cristian.marussi@....com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: arm: scmi property mboxes is not
 mandatory

On Fri, May 21, 2021 at 03:40:52PM +0200, Etienne Carriere wrote:
> Since "arm,scmi-smc" compatible support, mboxes property is not mandated.
> This change fixes the DT bindings description accordingly.
> 
> Cc: Rob Herring <robh@...nel.org>
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Etienne Carriere <etienne.carriere@...aro.org>
> ---
> Changes since v1:
>  - New patch is the series. Addresses mboxes propery description.
> ---
>  Documentation/devicetree/bindings/arm/arm,scmi.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> index 667d58e0a659..856d041b397e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt
> +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> @@ -15,10 +15,10 @@ Required properties:
>  The scmi node with the following properties shall be under the /firmware/ node.
>  
>  - compatible : shall be "arm,scmi" or "arm,scmi-smc" for smc/hvc transports
> -- mboxes: List of phandle and mailbox channel specifiers. It should contain
> -	  exactly one or two mailboxes, one for transmitting messages("tx")
> -	  and another optional for receiving the notifications("rx") if
> -	  supported.
> +- mboxes: List of phandle and mailbox channel specifiers. When used, it should
> +	  contain exactly one or two mailboxes, one for transmitting messages
> +	  ("tx") and another optional for receiving the notifications("rx") if
> +	  supported. Mandated by compatible "arm,scmi".

This change is not required with yaml as you can have right schema to reflect
this dependency. I think I already took care of this.

-- 
Regards,
Sudeep