linux-kernel - Re: [PATCH v2 3/3] arm64: dts: mt8183: remove syscon from smi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Jun 2021 14:15:24 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Hsin-Yi Wang <hsinyi@...omium.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        chun-jie.chen@...iatek.corp-partner.google.com,
        Yong Wu <yong.wu@...iatek.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: mt8183: remove syscon from smi_common
 node



On 01/06/2021 06:00, Hsin-Yi Wang wrote:
> We don't need to register smi_common as syscon. Also add required
> property power-domains for this node.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Applied to v5.13-next/dts64

Thanks!

> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a..e074c0d402ff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1263,13 +1263,14 @@ larb0: larb@...17000 {
>  		};
>  
>  		smi_common: smi@...19000 {
> -			compatible = "mediatek,mt8183-smi-common", "syscon";
> +			compatible = "mediatek,mt8183-smi-common";
>  			reg = <0 0x14019000 0 0x1000>;
>  			clocks = <&mmsys CLK_MM_SMI_COMMON>,
>  				 <&mmsys CLK_MM_SMI_COMMON>,
>  				 <&mmsys CLK_MM_GALS_COMM0>,
>  				 <&mmsys CLK_MM_GALS_COMM1>;
>  			clock-names = "apb", "smi", "gals0", "gals1";
> +			power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
>  		};
>  
>  		imgsys: syscon@...20000 {
>