[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMpxmJUogbSKEnm=c_s=yYwgCiLD6g56_k30jg84J+=v-=47yw@mail.gmail.com>
Date: Wed, 2 Jun 2021 15:34:49 +0200
From: Bartosz Golaszewski <bgolaszewski@...libre.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Serge Semin <Sergey.Semin@...kalelectronics.ru>,
linux-gpio <linux-gpio@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Hoan Tran <hoan@...amperecomputing.com>,
Serge Semin <fancer.lancer@...il.com>,
Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/2] gpio: dwapb: Drop redundant check in dwapb_irq_set_type()
On Tue, Jun 1, 2021 at 6:21 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> For more than 15 years we may not get into ->irq_set_type()
> without any meaningful type provided.
>
> Drop redundant check in dwapb_irq_set_type().
>
> See the commit e76de9f8eb67 ("[PATCH] genirq: add SA_TRIGGER support")
> out of curiosity.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/gpio/gpio-dwapb.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index d3233cc4b76b..939701c1465e 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -297,9 +297,6 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
> irq_hw_number_t bit = irqd_to_hwirq(d);
> unsigned long level, polarity, flags;
>
> - if (type & ~IRQ_TYPE_SENSE_MASK)
> - return -EINVAL;
> -
> spin_lock_irqsave(&gc->bgpio_lock, flags);
> level = dwapb_read(gpio, GPIO_INTTYPE_LEVEL);
> polarity = dwapb_read(gpio, GPIO_INT_POLARITY);
> --
> 2.30.2
>
Applied, thanks!
Bart
Powered by blists - more mailing lists