linux-kernel - Re: [PATCH][next] null_blk: Fix null pointer dereference on nullb->disk on blk_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB49650078EC900016480DFA59863C9@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Thu, 3 Jun 2021 00:00:15 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Colin King <colin.king@...onical.com>,
        Jens Axboe <axboe@...nel.dk>,
        Damien Le Moal <Damien.LeMoal@....com>,
        Christoph Hellwig <hch@....de>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] null_blk: Fix null pointer dereference on
 nullb->disk on blk_cleanup_disk call

On 6/2/21 03:07, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The error handling on a nullb->disk allocation currently jumps to
> out_cleanup_disk that calls blk_cleanup_disk with a null pointer causing
> a null pointer dereference issue. Fix this by jumping to out_cleanup_tags
> instead.
>
> Addresses-Coverity: ("Dereference after null check")
> Fixes: 132226b301b5 ("null_blk: convert to blk_alloc_disk/blk_cleanup_disk")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>