linux-kernel - Re: [PATCH -next] mfd: pm8008: Fix return value check in pm8008

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jun 2021 10:12:53 -0700
From:   Guru Das Srinagesh <gurus@...eaurora.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        lee.jones@...aro.org, agross@...nel.org
Subject: Re: [PATCH -next] mfd: pm8008: Fix return value check in
 pm8008_probe()

On Thu, Jun 03, 2021 at 10:13:57PM +0800, Yang Yingliang wrote:
> In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Acked-by: Guru Das Srinagesh <gurus@...eaurora.org>

> ---
>  drivers/mfd/qcom-pm8008.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index c472d7f8103c..dfefa60d693b 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -223,7 +223,7 @@ static int pm8008_probe(struct i2c_client *client)
>  	struct pm8008_data *chip;
>  
>  	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
> -	if (!chip)
> +	if (IS_ERR(chip))
>  		return -ENOMEM;
>  
>  	chip->dev = &client->dev;
> -- 
> 2.25.1
>