linux-kernel - Re: [PATCH] usb: dwc3-meson-g12a: fix usb2 PHY glue init when phy0 is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jun 2021 20:20:30 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     balbi@...nel.org, linux-usb@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3-meson-g12a: fix usb2 PHY glue init when phy0 is disabled

On Tue, Jun 1, 2021 at 10:49 AM Neil Armstrong <narmstrong@...libre.com> wrote:
>
> When only PHY1 is used (for example on Odroid-HC4), the regmap init code
> uses the usb2 ports when doesn't initialize the PHY1 regmap entry.
>
> This fixes:
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020
> ...
> pc : regmap_update_bits_base+0x40/0xa0
> lr : dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> ...
> Call trace:
> regmap_update_bits_base+0x40/0xa0
> dwc3_meson_g12a_usb2_init_phy+0x4c/0xf8
> dwc3_meson_g12a_usb2_init+0x7c/0xc8
> dwc3_meson_g12a_usb_init+0x28/0x48
> dwc3_meson_g12a_probe+0x298/0x540
> platform_probe+0x70/0xe0
> really_probe+0xf0/0x4d8
> driver_probe_device+0xfc/0x168
> ...
>
> Fixes: 013af227f58a97 ("usb: dwc3: meson-g12a: handle the phy and glue registers separately")
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>