linux-kernel - Re: [PATCH v2] driver core: Make cycle dev_info() message dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jun 2021 15:27:37 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] driver core: Make cycle dev_info() message dev_dbg()

On Thu, Jun 3, 2021 at 1:21 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> This seems to mostly print debug information about device link stuff at
> boot. It doesn't seem very useful outside of debugging so move it to
> dev_dbg().

As before, Nak at least for now.

This code path really shouldn't be exercised on most systems. I might
be open to this once fw_delink bug reports stop coming in for at least
1 full kernel minor version.

-Saravana


>
> Cc: Saravana Kannan <saravanak@...gle.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>
> Changes from v1 (https://lore.kernel.org/r/20210603064849.1376107-1-swboyd@chromium.org)
>  * Dropped second hunk and rebased to -rc4
>
>  drivers/base/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 54ba506e5a89..378bb894869a 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1736,7 +1736,7 @@ static int fw_devlink_create_devlink(struct device *con,
>                  */
>                 if (!device_link_add(con, sup_dev, flags) &&
>                     !(flags & DL_FLAG_SYNC_STATE_ONLY)) {
> -                       dev_info(con, "Fixing up cyclic dependency with %s\n",
> +                       dev_dbg(con, "Fixing up cyclic dependency with %s\n",
>                                  dev_name(sup_dev));
>                         device_links_write_lock();
>                         fw_devlink_relax_cycle(con, sup_dev);
>
> base-commit: 8124c8a6b35386f73523d27eacb71b5364a68c4c
> --
> https://chromeos.dev
>